guard against uint16_t overflows of Pixel ADC values [12_3_X]

[missirol]

backport of #38113

PR description:

See the original PR for the documentation of this change.

This PR prevents the possibility of a crash at HLT by avoiding the uint16_t-overflow of values used in the pixel local reconstruction.

PR validation:

Relies on the testing done for the original PR.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#38113

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_3_X.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from guard against uint16_t overflows of Pixel ADC values #38113

[missirol]

type bugfix

[missirol]

test parameters:

• enable_tests = gpu
• workflows_gpu = 11634.503, 11634.506, 11634.583, 11634.587
• workflow = 11634.501
• relvals_opt = -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12338f/25119/summary.html
COMMIT: e12ee0b
CMSSW: CMSSW_12_3_X_2022-05-31-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38149/25119/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 7
• DQMHistoTests: Total histograms compared: 76363
• DQMHistoTests: Total failures: 986
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 75377
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
• Checked 24 log files, 18 edm output root files, 7 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 97 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3643390
• DQMHistoTests: Total failures: 1749
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3641618
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 209 log files, 48 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

type trk

[jpata]

+reconstruction

• exact backport of guard against uint16_t overflows of Pixel ADC values #38113
• same comments apply as in guard against uint16_t overflows of Pixel ADC values #38113 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1
needed for next 12_3, as discussed at today's Ops meeting, also tested in master IB