-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to get the PU info from OnlineMetaData stream [Master] #38158
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38158/30313
|
A new Pull Request was created by @abhih1 (Abhirami Harilal) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8443e7/25158/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The Pileup information needed for the ML DQM plots was not being accessible as the ScalerStream from which it was taken, has been replaced by MetaDataStream [1]
This PR makes the necessary changes to get the PU information from the correct stream.
PR validation:
The code was validated by running the modified online Ecal DQM configuration and the PU info is accessed as expected.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
[1] https://gitlab.cern.ch/cmsos/worksuite/-/commit/c663f7b074b8d9f6e0a12f20d85a397b9ee8a0ef