New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runTheMatrix
: fix DeepCore Seeding PU Workflows
#38167
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38167/30316
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db1521/25153/summary.html Comparison SummarySummary:
|
+Upgrade This PR enable DeepCore Seeding on PU workflows. |
@cms-sw/pdmv-l2 kind ping. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all.
I noticed when trying to run the DeepCore workflow 11923.17 it was actually NOT running the DeepCore algorithm as the
--procModifiers seedingDeepCore
is not added to the cmsDriver command:PR validation:
After the change the command:
runTheMatrix.py --what upgrade -nel 11923.17
returns:
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
FYI: @bouchamaouihichem @vmariani @slava77