New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL - Fix dereferencing of nullptr in CaloRectangleRange #38173
ECAL - Fix dereferencing of nullptr in CaloRectangleRange #38173
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38173/30320
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ca930e/25207/summary.html Comparison SummarySummary:
|
+reconstruction
scram p -n CMSSW_12_5_UBSAN_X_2022-06-06-1100_PR CMSSW CMSSW_12_5_UBSAN_X_2022-06-06-1100
cd CMSSW_12_5_UBSAN_X_2022-06-06-1100_PR/src/
cmsenv
git cms-merge-topic cms-sw:38173
scram b -j8
runTheMatrix.py -l 10001.0 -t4 -j8
more 10001.0_SingleElectronPt10+2017+SingleElectronPt10_pythia8_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano/step3_SingleElectronPt10+2017+SingleElectronPt10_pythia8_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT+ALCA+Nano.log | grep "CaloSubdetectorTopology" | wc -l
0
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This fixes the dereferencing of a nullptr in the
CaloRectangleRange
constructor found by UBSAN and discussed in #37704.Store a pointer to the topology instead of a reference and handle the nullptr case when calculating the rectangle offset.
PR validation:
Passes limited matrix tests.