New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid reading off end of vector in SimTrackManager #38185
Conversation
Avoid dereferencing an iterator when it points to the end of the vector.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38185/30337
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20f6a1/25185/summary.html Comparison SummarySummary:
|
+1 @Dr15Jones , thanks! |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Avoid dereferencing an iterator when it points to the end of the vector.
Test using ASAN in a PR discovered this problem.
PR validation:
Code compiles.