Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Move counter initialization and printout+destruction to begin/endJob #38200

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jun 2, 2022

PR description:

Backport of #38145

This avoids possible exception being thrown in CAHitNtupletGeneratorOnGPU destructor that occurred in #38125.

PR validation:

Nothing beyond #38145

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38145

In order to avoid possibly throwing destructor. The CUDAService check
is still needed in begin/endJob for this module because the HLT
configuration stores the output of the transfer-to-host module, and
that keeps this module alive so that the non-Event transitions
(including begin/endJob) are called.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_12_3_X.

It involves the following packages:

  • RecoPixelVertexing/PixelTriplets (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Jun 2, 2022

enable gpu

@makortel
Copy link
Contributor Author

makortel commented Jun 2, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb8ac7/25206/summary.html
COMMIT: b66d812
CMSSW: CMSSW_12_3_X_2022-06-02-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38200/25206/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19864
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19854
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3627388
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3627358
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Jun 3, 2022

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2022

+1

@cmsbuild cmsbuild merged commit c68c889 into cms-sw:CMSSW_12_3_X Jun 4, 2022
@makortel makortel deleted the CAHitNtupletGeneratorOnGPUdestructor_123x branch July 6, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants