Cleanup redundant edm ParameterSet exist in RecoLuminosity

[jeongeun]

PR description:

(Technical PR) Optimization of the module configurations: Improve maintainability by cleaning up redundant cases of edm::ParameterSet calls to existAs or exist for tracked parameters, where redundancy is based on the value being already defined by fillDescriptions.

As follow the previous PR36746, PR36989, PR37313, PR37314, PR37548, PR37772, and PR37899.

The list of all calls of existAs or exist are automatically available in the Static Analyzer report. (Bug: CMS code rules)
It is accessible from IB page. https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/
For this task consider only modules or tools used by the modules that define fillDescriptions.

In this PR, 1 file was changed.
RecoLuminosity/LumiProducer/plugins/BunchSpacingProducer.cc

Here, the "overrideBunchSpacing", "bunchSpacingOverride" parameters were provided in a fillDescription.

cfipython/RecoLuminosity/LumiProducer/bunchSpacingProducer_cfi.py

PR validation:

Tested in CMSSW_12_4_X, the basic test all passed in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38218/30373

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• RecoLuminosity/LumiProducer (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf5c8b/25245/summary.html
COMMIT: 1da1a78
CMSSW: CMSSW_12_5_X_2022-06-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38218/25245/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3649923
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3649893
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical cleanup
• no reco changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1