Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Shorten PPS DiamondSampic ALCARECOStream name to fit into DBS database schema #38220

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #38209
This PR shortens the only remaining ALCARECOStream name in autoPCL that was still too long:

  • ALCARECOStreamPromptCalibProdPPSDiamondSampicTimingCalib
    is renamed
    ALCARECOStreamPromptCalibProdPPSDiamondSampic

PR validation:

Code compiles.
There are no data taken with PPS Diamond Sampic detector yet, so no relvals and no other test can be done at this point.
As soon as we get some data we will set up all the needed tests.

Backport:

Backport of #38209

FYI @vavati @grzanka @ChrisMisan

@francescobrivio
Copy link
Contributor Author

backport of #38209

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

  • CalibPPS/TimingCalibration (alca)
  • Configuration/AlCa (alca)
  • Configuration/StandardSequences (operations)

@perrotta, @malbouis, @yuanchao, @tvami, @cmsbuild, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @fabferro, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @rovere, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

type ctpps

@cmsbuild cmsbuild added the ctpps label Jun 3, 2022
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88efcc/25238/summary.html
COMMIT: be92a39
CMSSW: CMSSW_12_4_X_2022-06-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38220/25238/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3669912
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3669888
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

+alca

  • verbatim backport (cherry picking same commit) of the master PR

@francescobrivio
Copy link
Contributor Author

@cms-sw/orp-l2 this is basically fully signed!

@qliphy
Copy link
Contributor

qliphy commented Jun 6, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 2a721c8 into cms-sw:CMSSW_12_4_X Jun 6, 2022
@francescobrivio francescobrivio deleted the alca-fix_PPSname_PCL_12_4_X branch June 9, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants