[12.3.X] fix the ROOT type of EventStats monitor element in SiStripGainsPCLWorker

[mmusich]

backport of #38234

PR description:

I noticed when looking at recent 900GeV data that this particular plot has truncated entries at 32767 a.k.a. 0b111111111111111:

This happens because we are storing event and track counts with a short per channel, which is clearly insufficient for larger statistic runs.
This PR fixes that by making it a TH2I (which has become supported by the DQM infrastructure recently, thanks to #37665).

PR validation:

run unit tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38234

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

• CalibTracker/SiStripChannelGain (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @alesaggio, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from fix the ROOT type of EventStats monitor element in SiStripGainsPCLWorker #38234

[mmusich]

type bugfix,trk

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67090b/25271/summary.html
COMMIT: ad25ce8
CMSSW: CMSSW_12_3_X_2022-06-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38244/25271/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3627388
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3627358
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1