Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Pixel Heterogeneous DQM: add 1D differnce plots in vertex comparison module. #38253

Merged
merged 1 commit into from Jun 9, 2022

Conversation

sroychow
Copy link
Contributor

@sroychow sroychow commented Jun 6, 2022

PR description:

Backport of #38245

PR validation:

GPU wfs run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/SiPixelPhase1Heterogeneous (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@sroychow
Copy link
Contributor Author

sroychow commented Jun 6, 2022

test parameters:

  • enable_tests = gpu
  • workflows_gpu = 11634.503
  • relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

@sroychow
Copy link
Contributor Author

sroychow commented Jun 6, 2022

enable gpu

@sroychow
Copy link
Contributor Author

sroychow commented Jun 6, 2022

@cmsbuild please test

@sroychow
Copy link
Contributor Author

sroychow commented Jun 6, 2022

backport of #38245

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbf918/25297/summary.html
COMMIT: 9ce730a
CMSSW: CMSSW_12_4_X_2022-06-05-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38253/25297/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 39634.9939634.99_TTbar_14TeV+2026D88PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D88PU_PMXS1S2+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 5
  • DQMHistoTests: Total histograms compared: 36035
  • DQMHistoTests: Total failures: 62
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 35971
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 299.085 KiB( 4 files compared)
  • DQMHistoSizes: changed ( 11634.503 ): 299.085 KiB SiPixelHeterogeneous/PixelVertexCompareSoAGPUvsCPU
  • Checked 16 log files, 12 edm output root files, 5 DQM output files
  • TriggerResults: found differences in 4 / 4 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3671502
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3671472
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jun 6, 2022

@cmsbuild, please test

  • let's try again

@mmusich
Copy link
Contributor

mmusich commented Jun 6, 2022

type tracking

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbf918/25315/summary.html
COMMIT: 9ce730a
CMSSW: CMSSW_12_4_X_2022-06-06-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38253/25315/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 5
  • DQMHistoTests: Total histograms compared: 36035
  • DQMHistoTests: Total failures: 59
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 35974
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 299.085 KiB( 4 files compared)
  • DQMHistoSizes: changed ( 11634.503 ): 299.085 KiB SiPixelHeterogeneous/PixelVertexCompareSoAGPUvsCPU
  • Checked 16 log files, 12 edm output root files, 5 DQM output files
  • TriggerResults: found differences in 3 / 4 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3671502
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3671466
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

again that doesn't look related to this PR

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbf918/25330/summary.html
COMMIT: 9ce730a
CMSSW: CMSSW_12_4_X_2022-06-06-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38253/25330/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 5
  • DQMHistoTests: Total histograms compared: 36035
  • DQMHistoTests: Total failures: 17
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 36016
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 299.085 KiB( 4 files compared)
  • DQMHistoSizes: changed ( 11634.503 ): 299.085 KiB SiPixelHeterogeneous/PixelVertexCompareSoAGPUvsCPU
  • Checked 16 log files, 12 edm output root files, 5 DQM output files
  • TriggerResults: found differences in 1 / 4 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3671502
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3671466
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 9, 2022

+1

@cmsbuild cmsbuild merged commit 4648b2e into cms-sw:CMSSW_12_4_X Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants