move test_CreateFileLists test to CommonAlignment

[smuzaffar]

As tkal_create_file_lists.py is part of Alignment/CommonAlignment package , so this PR proposes to move unit test test_CreateFileLists in to Alignment/CommonAlignment .

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38296/30457

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/MillePedeAlignmentAlgorithm/test/BuildFile.xml modified in PR(s): Adding HZZ electron MVA ID #37429

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Alignment/CommonAlignment (alca)
• Alignment/MillePedeAlignmentAlgorithm (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

@cms-sw/alca-l2 , should I drop https://github.com/cms-sw/cmssw/blob/master/Alignment/MillePedeAlignmentAlgorithm/scripts/mps_create_file_lists.py too ? This was previously used by test_CreateFileLists unit test . If nothing outside cmssw is using it then I suggest to drop it too?

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12e9a/25385/summary.html
COMMIT: 8eac8e9
CMSSW: CMSSW_12_5_X_2022-06-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38296/25385/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3652078
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3652036
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

, should I drop https://github.com/cms-sw/cmssw/blob/master/Alignment/MillePedeAlignmentAlgorithm/scripts/mps_create_file_lists.py too ? This was previously used by test_CreateFileLists unit test . If nothing outside cmssw ising calling it then I suggest to drop it too?

Taking the liberty of tagging @connorpa @antoniovagnerini @consuegs (but I think it should be dropped)

[tvami]

type trk

[tvami]

@smuzaffar will you do the drop in this PR? I'll wait with signing this then

[smuzaffar]

please test

@smuzaffar will you do the drop in this PR? I'll wait with signing this then

@tvami , I just have update this PR to drop mps_create_file_lists.py

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38296/30479

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/MillePedeAlignmentAlgorithm/test/BuildFile.xml modified in PR(s): Adding HZZ electron MVA ID #37429

[cmsbuild]

Pull request #38296 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b12e9a/25401/summary.html
COMMIT: 75b384a
CMSSW: CMSSW_12_5_X_2022-06-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38296/25401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3652078
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3652048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1