Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix range in recHitsEndcapsPosXY #38326

Merged
merged 1 commit into from Jun 13, 2022
Merged

Conversation

silviodonato
Copy link
Contributor

PR description:

During a fast track validation of HLT of a global tag @elfontan and @swagata87 found the error [1]
which complains that the range of recHitsEndcapsPosXY changed between the lumisections.
Looking at the code, the bug is evident and the bug fix is very trivial.

[1]

getting timing results...
Info in <TH2F::Add>: Attempt to add histograms with different axis limits - trying to use TH1::Merge
Error in <Merge>: Cannot merge histograms - limits are inconsistent:
 first: recHitsEndcapsPosXY (200, -19.000000, 18.600000), second: recHitsEndcapsPosXY (200, -19.000000, 18.800000)
Info in <TH2F::Add>: Attempt to add histograms with different axis limits - trying to use TH1::Merge
Error in <Merge>: Cannot merge histograms - limits are inconsistent:
 first: recHitsEndcapsPosXY (200, -19.000000, 18.600000), second: recHitsEndcapsPosXY (200, -19.000000, 18.800000)
DEBUG: Converting file /cmsnfsscratch/globalscratch/hltpro/fastTrack/reference_run352929/ref_DQM_hists.pb

[reference] DQM histograms (including timing) dumped to: ref_DQM_hists.root (copy to lxplus and open in TBrowser to examine timing plots)
Info in <TH2F::Add>: Attempt to add histograms with different axis limits - trying to use TH1::Merge
Error in <Merge>: Cannot merge histograms - limits are inconsistent:
 first: recHitsEndcapsPosXY (200, -19.000000, 18.000000), second: recHitsEndcapsPosXY (200, -19.000000, 18.800000)
Info in <TH2F::Add>: Attempt to add histograms with different axis limits - trying to use TH1::Merge
Error in <Merge>: Cannot merge histograms - limits are inconsistent:
 first: recHitsEndcapsPosXY (200, -19.000000, 18.000000), second: recHitsEndcapsPosXY (200, -19.000000, 18.800000)
Info in <TH2F::Add>: Attempt to add histograms with different axis limits - trying to use TH1::Merge
Error in <Merge>: Cannot merge histograms - limits are inconsistent:
 first: recHitsEndcapsPosXY (200, -19.000000, 18.000000), second: recHitsEndcapsPosXY (200, -19.000000, 18.800000)
Info in <TH2F::Add>: Attempt to add histograms with different axis limits - trying to use TH1::Merge
Error in <Merge>: Cannot merge histograms - limits are inconsistent:
 first: recHitsEndcapsPosXY (200, -19.000000, 18.000000), second: recHitsEndcapsPosXY (200, -19.000000, 18.800000)
DEBUG: Converting file /cmsnfsscratch/globalscratch/hltpro/fastTrack/test_run352929/test_DQM_hists.pb
[test, GT=123X_dataRun3_HLT_v11] DQM histograms (including timing) dumped to: test_DQM_hists.root (copy to lxplus and open in TBrowser to examine timing plots)
End of script.

PR validation:

Very trivial bug fix, I admit no validation...

if this PR is a backport please specify the original PR and why you need to backport that PR:

We will need a backport down to 12_3_X for the data taking

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38326/30504

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

  • DQM/SiPixelPhase1Heterogeneous (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @fioriNTU, @jandrea, @idebruyn, @mmusich, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@swagata87
Copy link
Contributor

swagata87 commented Jun 10, 2022

type bug-fix

@tvami
Copy link
Contributor

tvami commented Jun 10, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor

tvami commented Jun 10, 2022

type trk

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b34a8/25440/summary.html
COMMIT: d519626
CMSSW: CMSSW_12_5_X_2022-06-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38326/25440/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b34a8/25440/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b34a8/25440/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3658678
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3658642
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 13, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants