[Backport] Updates related to the L1 menu v1_1_0 for the start of Run 3

[elfontan]

PR description:

Backport of #38250 to CMSSW_12_4_0.

A full set of xml files for the L1 emulation of prescales and masks coherent with the updated L1 menu for Run 3 has been created and pushed to L1Trigger-L1TGlobal (PR#11). A backport of these files has been requested in the github issue cms-data/L1Trigger-L1TGlobal#12. Changes will be backported to CMSSW_12_4_0 in cms-sw/cmsdist after the tests: PR#7926 for 12_4_X cms-dist ready.

PR validation:

Basic tests performed successfully starting from CMSSW_12_4_X_2022-06-10-2300.

cmsrel CMSSW_12_4_X_2022-06-10-2300
cd CMSSW_12_4_X_2022-06-10-2300/src
cmsenv
git cms-addpkg L1Trigger/Configuration
git cms-addpkg L1Trigger/L1TGlobal
cd L1Trigger/L1TGlobal
mkdir -p data/Luminosity/startup
wget https://raw.githubusercontent.com/cms-l1-dpg/L1MenuRun3/master/development/L1Menu_Collisions2022_v1_1_0/L1Menu_Collisions2022_v1_1_0.xml
cd -
git cherry-pick df9c038
scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format

[cmsbuild]

A new Pull Request was created by @elfontan (Elisa Fontanesi) for CMSSW_12_4_X.

It involves the following packages:

• L1Trigger/Configuration (l1)
• L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from New set of files coherent with the new v1_1_0 L1Menu #38250

[smuzaffar]

please test with cms-sw/cmsdist#7926

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14cc25/25486/summary.html
COMMIT: 6319e9a
CMSSW: CMSSW_12_4_X_2022-06-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38331/25486/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test L1O2O_L1TMenu had ERRORS
---> test L1O2O_L1TSubs had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3679963
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3679933
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[missirol]

test parameters:

• pull_requests = [12.4.X] Updated files for the v1_1_0 menu for Run 3 (and minor fix for v1_0_0) cmsdist#7926
• cms-addpkg = CondTools/L1TriggerExt

[missirol]

please test with cms-sw/cmsdist#7926

Let's see if #38331 (comment) helps (I encountered the same issue locally; looks like the new L1T unit test expects the other pkg to be checked out locally). What I'm missing is why the unit test did not run in the original PR (here); maybe this is related to #38331 (comment) (the original PR was tested without any externals required).

[missirol]

backport of #38250

[missirol]

please abort

[missirol]

please test

My bad, I had to fix #38331 (comment).

[missirol]

What I'm missing is why the unit test did not run in the original PR

From this PR I see [1], while from the original PR I see [2]. I'm not sure why. Naively, I would expect [1] even in 12_5_X, because L1TriggerConfig/L1TConfigProducers/python/L1TGlobalPrescalesVetosOnline_cfi.py depends on PrescalesVetos_cff, so I'm missing something.

[1] https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/25498/consoleText

+ git cms-checkdeps -A -a
>> Checking L1Trigger/Configuration CMSSW_12_4_X_2022-06-13-1100
   x L1Trigger/Configuration/python/customiseUtils.py
>> Checking L1Trigger/L1TGlobal CMSSW_12_4_X_2022-06-13-1100
   x L1Trigger/L1TGlobal/python/PrescalesVetosFract_cff.py
   x L1Trigger/L1TGlobal/python/PrescalesVetos_cff.py
   x L1Trigger/L1TGlobal/test/runGlobalFakeInputProducer.py
Checking out these packages: 1
L1TriggerConfig/L1TConfigProducers (python)

[2] https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/25288/consoleText

+ git cms-checkdeps -A -a
>> Checking L1Trigger/Configuration CMSSW_12_5_X_2022-06-05-0000
   x L1Trigger/Configuration/python/customiseUtils.py
>> Checking L1Trigger/L1TGlobal CMSSW_12_5_X_2022-06-05-0000
   x L1Trigger/L1TGlobal/python/PrescalesVetosFract_cff.py
   x L1Trigger/L1TGlobal/python/PrescalesVetos_cff.py
   x L1Trigger/L1TGlobal/test/runGlobalFakeInputProducer.py
Checking out these packages: 0

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14cc25/25498/summary.html
COMMIT: 6319e9a
CMSSW: CMSSW_12_4_X_2022-06-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38331/25498/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3679963
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3679939
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Verbatim backport of New set of files coherent with the new v1_1_0 L1Menu #38250
• To be merged together with [12.4.X] Updated files for the v1_1_0 menu for Run 3 (and minor fix for v1_0_0) cmsdist#7926

[missirol]

Hi @smuzaffar ,

just for my understanding, would you mind having a look at #38331 (comment) , and explaining if this is the expected behaviour of the PR tests?

It seems that changes in L1Trigger/L1TGlobal/python lead to the check-out of L1TriggerConfig/L1TConfigProducers in 12_4_X, but not in 12_5_X (even though the relevant code seems to be the same in the two cycles).

[smuzaffar]

@missirol , looks like the python dependency check is broken in 12.5.X as the dependency files in 12.5.X are

> ls -l CMSSW_12_5_X_2022-06-05-0000/etc/dependencies
-rw-r--r--. 1 500 500   421099 Jun  5 08:01 bfusedby.out.gz
-rw-r--r--. 1 500 500   112710 Jun  5 08:01 bfuses.out.gz
-rw-r--r--. 1 500 500   136579 Jun  5 08:01 prod2src.out.gz
-rw-r--r--. 1 500 500       33 Jun  5 08:01 pyusedby.out.gz
-rw-r--r--. 1 500 500       31 Jun  5 08:01 pyuses.out.gz
-rw-r--r--. 1 500 500 21918705 Jun  5 08:01 usedby.out.gz
-rw-r--r--. 1 500 500  6287541 Jun  5 08:01 uses.out.gz

while in 12.4.X we have

-rw-r--r--. 1 500 500   425503 Jun 13 12:00 bfusedby.out.gz
-rw-r--r--. 1 500 500   114322 Jun 13 12:00 bfuses.out.gz
-rw-r--r--. 1 500 500   142334 Jun 13 12:00 prod2src.out.gz
-rw-r--r--. 1 500 500   216928 Jun 13 12:00 pyusedby.out.gz
-rw-r--r--. 1 500 500   166089 Jun 13 12:00 pyuses.out.gz
-rw-r--r--. 1 500 500 21984056 Jun 13 12:00 usedby.out.gz
-rw-r--r--. 1 500 500  6301191 Jun 13 12:00 uses.out.gz

I am checking what broken it

[smuzaffar]

@missirol , cms-sw/cmsdist#7932 shoudl fix the python dependency issue

[missirol]

Thanks, @smuzaffar !