Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibTracker: fallback to the OnlineLuminosityRecord when SCAL is not available #38384

Merged
merged 1 commit into from Jun 16, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 16, 2022

PR description:

It was noticed during 2022 900GeV collision runs that the information for PU and instantaneous luminosity is always identically zero for all runs (see e.g.: https://tinyurl.com/25cqyvlu).
This is due to the fact that the online PU and inst. luminosity information were taken from the SCAL FED digis which are not available anymore in Run-3. This PR fixes the problem by adding a fall-back to the OnlineLuminosityRecord provided by the S/W FED 1023.

PR validation:

cmssw compiles, unit tests are running correctly.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but needs to be backported all the way down to 12.3.X.

@mmusich mmusich changed the title CalibTracker: fallback to the OnlineLuminosityRecord when SCAL is not available CalibTracker: fallback to the OnlineLuminosityRecord when SCAL is not available Jun 16, 2022
@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Jun 16, 2022
@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2022

type bugfix,trk

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38384/30580

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiStripCommon (alca)
  • CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2022

please test

@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2022

FYI @robervalwalsh @mdelcourt @jlagram

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fbd66/25552/summary.html
COMMIT: 06a9674
CMSSW: CMSSW_12_5_X_2022-06-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38384/25552/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659074
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3659044
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 16, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jun 16, 2022

Although there is this dead initialization
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fbd66/25552/llvm-analysis/report-9c8e4f.html#EndPath
Not sure if we want to fix it in this PR....

@mmusich
Copy link
Contributor Author

mmusich commented Jun 16, 2022

Not sure if we want to fix it in this PR....

clearly beyond the scope.

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants