Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Fix output file name of hcalgpu DQM client #38412

Merged
merged 1 commit into from Jun 18, 2022

Conversation

pmandrik
Copy link
Contributor

PR description:

The output file name of hcalgpu DQM client is the same as of hcal client. Because of this the files are randomly overwritten messing the online dqm GUI ( e.g. compare /Hcal folders for runs 353910 and 353909 ). PR changing 'Hcal' prefix to 'HcalGPU'.

PR validation:

Tested at P5

if this PR is a backport please specify the original PR and why you need to backport that PR:

#38411

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2022

A new Pull Request was created by @pmandrik for CMSSW_12_3_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@pmandrik
Copy link
Contributor Author

please test

@pmandrik pmandrik changed the title [12_3_X] Update hcalgpu_dqm_sourceclient-live_cfg.py [12_3_X] Fix output file name of hcalgpu DQM client Jun 17, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-533d6b/25598/summary.html
COMMIT: 8f824ce
CMSSW: CMSSW_12_3_X_2022-06-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38412/25598/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-533d6b/25598/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-533d6b/25598/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3630290
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3630260
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #38411

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2567ff6 into cms-sw:CMSSW_12_3_X Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants