Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.3.X] Update SiStrip and TkAlignment ALCARECO event content for Run3 #38430

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 20, 2022

backport of #38415

PR description:

In relation to PR #38386, update also the event content of the input ALCARECO event contents to use S/W FED 1023 information instead of SCAL for all the relevant SiStrip and TkAlignment alcas.

PR validation:

run runTheMatrix.py -nel 138.4 and manually checked that the event content of the output files is the desired one.

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38415 in case a new 12.3.X is built

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Calibration/TkAlCaRecoProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @threus, @tocheng, @tlampen, @mmusich, @ChrisMisan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 20, 2022

type trk

@cmsbuild cmsbuild added the trk label Jun 20, 2022
@tvami
Copy link
Contributor

tvami commented Jun 20, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4c705/25622/summary.html
COMMIT: 8fb670c
CMSSW: CMSSW_12_3_X_2022-06-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38430/25622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3630290
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3630266
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 20, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8e995cd into cms-sw:CMSSW_12_3_X Jun 20, 2022
@mmusich mmusich deleted the updateAlCaRecoEventContentForRun3_12_3_X branch June 20, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants