Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Fix for printouts with special (for python) chars #38433

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #38140
Fixes the listing functions of conddb from command line.

PR validation:

Master PR is alredy integrated in CMSSW_12_5_0_pre2 and the conddb command works as expected.

Backport:

Backport of #38140

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

  • CondCore/Utilities (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

type bug-fix

@francescobrivio
Copy link
Contributor Author

backport of #38140

@francescobrivio
Copy link
Contributor Author

Not urgent, not needed for operations
Just to have a working conddb command in case a new 12_3_X release is cut.

@francescobrivio
Copy link
Contributor Author

test parameters:

  • addpkg = CondTools

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7efc71/25624/summary.html
COMMIT: 7a33f2e
CMSSW: CMSSW_12_3_X_2022-06-19-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38433/25624/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3630290
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3630260
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 20, 2022

+db

  • problem is understood and unrelated

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 311f576 into cms-sw:CMSSW_12_3_X Jun 20, 2022
@francescobrivio francescobrivio deleted the alca-fix_conddb_commands_12_3_X branch June 21, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants