Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of HLTriggerJSONMonitoring for DatasetPaths [12_3_X] #38446

Conversation

missirol
Copy link
Contributor

backport of #38418

PR description:

This PR updates the plugin HLTriggerJSONMonitoring to take into account the presence of the so-called DatasetPaths in the Run-3 HLT menus; see the description of the original PR for further details.

This PR is a nice-to-have for the next 12_3_X release. It will correct the rates of Primary Datasets as reported in (some tables of) OMS.

PR validation:

None. Relies on the validation done for the original PR.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#38418

Update of an HLT utility relevant to data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_3_X.

It involves the following packages:

  • HLTrigger/JSONMonitoring (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-449f81/25653/summary.html
COMMIT: 73fe513
CMSSW: CMSSW_12_3_X_2022-06-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38446/25653/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3630290
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3630266
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 22, 2022

+1

@cmsbuild cmsbuild merged commit f46bc66 into cms-sw:CMSSW_12_3_X Jun 22, 2022
@missirol missirol deleted the devel_hltJsonMonitoringWithDatasetPaths_123X branch June 23, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants