Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made FebConnectorSpec const thread-safe #38475

Merged
merged 1 commit into from Jun 23, 2022
Merged

Made FebConnectorSpec const thread-safe #38475

merged 1 commit into from Jun 23, 2022

Conversation

Dr15Jones
Copy link
Contributor

PR description:

As this is used in an EventSetup data product, it must be const thread-safe.

This was found by the static analyzer.

PR validation:

Code compiles.

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Jun 22, 2022
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38475/30689

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • CondFormats/RPCObjects (db, alca)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @ChrisMisan, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@tvami
Copy link
Contributor

tvami commented Jun 22, 2022

type performance-improvement,rpc

@tvami
Copy link
Contributor

tvami commented Jun 22, 2022

test parameters:

  • enable_tests = threading

@tvami
Copy link
Contributor

tvami commented Jun 22, 2022

@cmsbuild , please test

  • let's do a test with threading too

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT RelVals-THREADING AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e226d7/25707/summary.html
COMMIT: 7ed4266
CMSSW: CMSSW_12_5_X_2022-06-22-1100/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38475/25707/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 22-Jun-2022 20:56:27 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 274199 lumi: 21 event: 39389360 stream: 0
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1TDigiToRaw/'packGmtStage2'
   [5] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [6] Calling method for module RPCUnpackingModule/'unpackRPC'
Exception Message:
A std::exception was thrown.
basic_string::_M_construct null not valid
----- End Fatal Exception -------------------------------------------------
  • 136.874136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step2_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log
  • 5.1
----- Begin Fatal Exception 22-Jun-2022 20:57:37 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Calling method for module RPCPackingModule/'rpcpacker'
Exception Message:
A std::exception was thrown.
basic_string::_M_construct null not valid
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 6.06.0_SingleMuPt1+SingleMuPt1INPUT+DIGI+RECO+HARVEST/step2_SingleMuPt1+SingleMuPt1INPUT+DIGI+RECO+HARVEST.log
  • 11.011.0_MinBias+MinBiasINPUT+DIGI+RECOMIN+HARVEST+ALCAMIN/step2_MinBias+MinBiasINPUT+DIGI+RECOMIN+HARVEST+ALCAMIN.log
  • 15.015.0_SingleElectronPt10+SingleElectronPt10INPUT+DIGI+RECO+HARVEST/step2_SingleElectronPt10+SingleElectronPt10INPUT+DIGI+RECO+HARVEST.log
Expand to see more relval errors ...

RelVals-THREADING

  • 4.224.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log
  • 5.15.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
  • 25.025.0_TTbar+TTbarINPUT+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbarINPUT+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 22-Jun-2022 20:57:42 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 1
   [1] Running path 'RAWSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'RAWSIMoutput'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Calling method for module RPCPackingModule/'rpcpacker'
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 22-Jun-2022 21:01:04 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:RelVal_Raw_Fake2_MC.root could not be opened.
      [b] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 258. Asked to read n bytes: 300 from offset: 0 with file size: 258

----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 22-Jun-2022 21:03:14 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:RelVal_Raw_Fake_MC.root could not be opened.
      [b] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@Dr15Jones
Made FebConnectorSpec const thread-safe
27f0b69 
As this is used in an EventSetup data product, it must be const
thread-safe.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38475/30700

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38475 was updated. @ggovi, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e226d7/25734/summary.html
COMMIT: 27f0b69
CMSSW: CMSSW_12_5_X_2022-06-23-1100/el8_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38475/25734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659307
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3659259
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 23, 2022

+1

  • THREADING tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0aff7a1 into cms-sw:master Jun 23, 2022
@Dr15Jones Dr15Jones deleted the threadSafeFebConnectorSpec branch June 28, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved db-approved fully-signed orp-approved performance-improvements rpc tests-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @tvami @perrotta