Factor of 2 bugfix for HF PF rechits w/ short-fiber only (12_4_X backport)

[mandrenguyen]

PR description:

Backport of #38464

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_12_4_X.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @rovere, @lgray, @lecriste, @hatakeyamak, @ebrondol, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Factor of 2 bugfix for HF PF rechits w/ short-fiber only #38464

[perrotta]

backport of #38464

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dad76/25748/summary.html
COMMIT: 8aae610
CMSSW: CMSSW_12_4_X_2022-06-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38487/25748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11057 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3680359
• DQMHistoTests: Total failures: 5310
• DQMHistoTests: Total nulls: 4
• DQMHistoTests: Total successes: 3675023
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.035 KiB( 49 files compared)
• DQMHistoSizes: changed ( 138.4 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 138.5 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 49 workflows

[clacaputo]

+reconstruction

• Backport of Factor of 2 bugfix for HF PF rechits w/ short-fiber only #38464
• bp is in line with the original PR
• backport has been discussed during 23Jun PPD GM

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Pull request #38487 was updated. @jpata, @cmsbuild, @clacaputo can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dad76/25798/summary.html
COMMIT: ed66c69
CMSSW: CMSSW_12_4_X_2022-06-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38487/25798/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 11055 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3680359
• DQMHistoTests: Total failures: 5304
• DQMHistoTests: Total nulls: 5
• DQMHistoTests: Total successes: 3675028
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.039 KiB( 49 files compared)
• DQMHistoSizes: changed ( 138.4 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 138.5 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 3 / 49 workflows

[perrotta]

urgent

[clacaputo]

+reconstruction

• re-sign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1
(Thank you @clacaputo )