Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gen fragment for LLP relval #38496

Merged
merged 3 commits into from Jul 26, 2022
Merged

Conversation

kakwok
Copy link
Contributor

@kakwok kakwok commented Jun 24, 2022

This PR is for adding the gen-fragment for relval sample for the new LLP seeds as per dicussion here:

https://its.cern.ch/jira/browse/PDMVRELVALS-152

The fragment is taken from the signal sample used in the TSG sample:
https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_fragment/HCA-Run3Winter20GS-00030/0

The backport to 12_4_X is #38490

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38496/30719

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kakwok for master.

It involves the following packages:

  • Configuration/Generator (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Jun 27, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6e2a0/25835/summary.html
COMMIT: 9dcb610
CMSSW: CMSSW_12_5_X_2022-06-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38496/25835/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659995
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3659971
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@SiewYan
Copy link
Contributor

SiewYan commented Jun 28, 2022

@kakwok , thanks for the PR. Have you performed validation locally on this fragment? Do you mind sharing it here? Thanks

@kakwok
Copy link
Contributor Author

kakwok commented Jun 28, 2022

Hi @SiewYan , do you have instructions to perform the validation?
I have not done it myself, but it's directly taken from the TSG campaign for Run 3 MC here:
https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_fragment/HCA-Run3Winter20GS-00030/0

Is this good enough?

@Saptaparna
Copy link
Contributor

Saptaparna commented Jul 5, 2022

Hi, do you want this to target 13.6 TeV or 14 TeV? Run III is 13.6 TeV as you know.

@Saptaparna
Copy link
Contributor

Saptaparna commented Jul 5, 2022

Following up, since this a configuration file:
Pythia8GeneratorFilter -> Pythia8ConcurrentHadronizerFilter

@kakwok
Copy link
Contributor Author

kakwok commented Jul 8, 2022

Hi @Saptaparna, thanks for your help! I've updated the PR as per your suggestion.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38496/30944

  • This PR adds an extra 28KB to repository

@SiewYan
Copy link
Contributor

SiewYan commented Jul 18, 2022

-1

@SiewYan
Copy link
Contributor

SiewYan commented Jul 18, 2022

Awaiting changes suggested on #38496 (comment)

@SiewYan
Copy link
Contributor

SiewYan commented Jul 25, 2022

@kakwok , do you have any update on the suggested changes? Thanks.

@kakwok
Copy link
Contributor Author

kakwok commented Jul 25, 2022

@SiewYan Sorry for the late response. Just fixed it.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38496/31239

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38496 was updated. @cmsbuild can you please check and sign again.

@SiewYan
Copy link
Contributor

SiewYan commented Jul 25, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6e2a0/26432/summary.html
COMMIT: fa7720d
CMSSW: CMSSW_12_5_X_2022-07-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38496/26432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3667670
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3667628
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@SiewYan
Copy link
Contributor

SiewYan commented Jul 26, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d103406 into cms-sw:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants