[Backport of] HCAL: Bugfix of PFA1' Trigger Primitive algo by removing peak-finder

[Michael-Krohn]

PR description:

Removing the peak-finder when the FIR filter, PFA1', is running to reconstruct the TP energy. This is to match what is in the firmware on detector. Also, on detector the peak-finder is only run when PFA2 is enabled, which has been implemented in this modification.

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of PR #38488 to 124X, in order to make s/w match f/w.

[cmsbuild]

A new Pull Request was created by @Michael-Krohn for CMSSW_12_4_X.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimAlgos (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from HCAL: Bugfix of PFA1' Trigger Primitive algo by removing peak-finder #38488

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b73afb/25822/summary.html
COMMIT: 66db876
CMSSW: CMSSW_12_4_X_2022-06-26-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38501/25822/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3675241
• DQMHistoTests: Total failures: 1097
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3674121
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 1 / 49 workflows

[perrotta]

@cecilecaillol @epalencia please consider signing if you want this in 12_4_1: I think this should be included in the MC production release 12_4_1

[perrotta]

urgent

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #38488

[perrotta]

+1

• It can be merged, as it shouldn’t affect the PU libraries, as confirmed by PPD in a e-mail thread