[12_4_X Backport] Add checks for ECAL DQM setup objects to prevent crashes on runs with no calibration data

[alejands]

PR description:

This is an urgent fix and needs to be included in the production version at P5 as soon as possible.

This PR fixes an issue causing the client DQM/Integration/python/clients/ecalcalib_dqm_sourceclient-live_cfg.py to crash when there is no calibration data available as shown here: https://cmsweb.cern.ch/dqm/dqm-square/tmp/content_parser_productionPARSER_run354309.

See error log file here: https://cmsweb.cern.ch/dqm/dqm-square/tmp/tmp/content_parser_productionPARSER_run354309PARSER_job9.log

%MSG-e EcalDQM:  EcalDQMonitorClient:ecalCalibMonitorClient@endProcessBlock  24-Jun-2022 02:45:57 CEST post-events
EcalCalib Monitor Client: Exception in bookMEs @ LaserClient
%MSG
----- Begin Fatal Exception 24-Jun-2022 02:45:57 CEST-----------------------
An exception of category 'InvalidCall' occurred while
   [0] Processing end ProcessBlock
   [1] Calling method for module EcalDQMonitorClient/'ecalCalibMonitorClient'
Exception Message:
Electronics Mapping not initialized
----- End Fatal Exception -------------------------------------------------

The crashes were due to one of the global variables removed in #33200 being called without being initialized. This PR reintroduces the check functions (eg. checkElectronicsMap()) that existed before #33200 and uses them to prevent running the code that crashes when there's nothing to run over.

PR validation:

ecalcalib_dqm_sourceclient-live_cfg.py no longer crashes in this scenario

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #38503 to include this in the production version at P5 as soon as possible

[cmsbuild]

A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_12_4_X.

It involves the following packages:

• DQM/EcalCommon (dqm)
• DQM/EcalMonitorClient (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Add checks for ECAL DQM setup objects to prevent crashes on runs with no calibration data #38503

[emanueleusai]

please test

[emanueleusai]

type ecal

[emanueleusai]

backport of #38503

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9afaeb/25773/summary.html
COMMIT: 9ae0e80
CMSSW: CMSSW_12_4_X_2022-06-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38504/25773/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3680359
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3680329
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

type bug

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1