Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Update of ECAL conditions for Run3 MC production 12_4 #38515

Merged
merged 1 commit into from Jun 28, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jun 27, 2022

PR description:

See #38514

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38514

@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Jun 27, 2022
@tvami
Copy link
Contributor Author

tvami commented Jun 27, 2022

Backport of #38514

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @Martin-Grunewald, @missirol, @mmusich, @ChrisMisan, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jun 27, 2022

type ecal

@cmsbuild cmsbuild added the ecal label Jun 27, 2022
@tvami tvami changed the title Update of ECAL conditions for Run3 MC production 12_4 [12_4_X] Update of ECAL conditions for Run3 MC production 12_4 Jun 27, 2022
@tvami
Copy link
Contributor Author

tvami commented Jun 27, 2022

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@tvami
Copy link
Contributor Author

tvami commented Jun 27, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

Pull request #38515 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Jun 27, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-89bbbb/25825/summary.html
COMMIT: 80d2714
CMSSW: CMSSW_12_4_X_2022-06-26-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38515/25825/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89bbbb/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-89bbbb/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17706 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4145379
  • DQMHistoTests: Total failures: 18057
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 4127298
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.129 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): -2.133 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 227 log files, 45 edm output root files, 54 DQM output files
  • TriggerResults: found differences in 6 / 53 workflows

@tvami
Copy link
Contributor Author

tvami commented Jun 27, 2022

urgent

  • should go into the release built tomorrow

@francescobrivio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ac5ea96 into cms-sw:CMSSW_12_4_X Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants