Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tool to convert data to the .raw format used as input by the HLT [12.4.x] #38520

Merged
merged 1 commit into from Jun 29, 2022

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 27, 2022

PR description:

Add convertToRaw, a script that converts RAW data stored in one or more EDM .root files into the .raw file format used as input by the HLT.

usage: convertToRaw [-h] [-o PATH] [-f EVENTS] [-l EVENTS] [--one-file-per-lumi] FILES [FILES ...]

Convert RAW data from .root format to .raw format.

positional arguments:
  FILES                 input files in .root format

optional arguments:
  -h, --help            show this help message and exit
  -o PATH, --output PATH
                        base path to store the output files; subdirectories based on the run number are automatically created (default: )
  -f EVENTS, --events_per_file EVENTS
                        split the output into files with at most EVENTS events (default: 50)
  -l EVENTS, --events_per_lumi EVENTS
                        process at most EVENTS events in each lumisection (default: 11650)
  --one-file-per-lumi   assume that lumisections are not split across files (and disable --events_per_lumi) (default: False)

The default behaviour is to process a single luminosity section at a time, in order to support luminosity sections split across multiple files and a limit on the number of events in each lumisection.

If neither of these features is needed (i.e. if lumisections are not split, and all events should be converted) the --one-file-per-lumi can be used to process all data with a single job, speeding up the conversion considerably.

PR validation:

The files produced by convertToRaw can be used as input by an online-like HLT job.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38519 .

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 27, 2022

backport #38519

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

  • HLTrigger/Tools (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 27, 2022

please test

To make the bot happy. even if the new tool does not affect any workflow.

@cmsbuild
Copy link
Contributor

Pull request #38520 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 27, 2022

please test

@cmsbuild
Copy link
Contributor

Pull request #38520 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 27, 2022

please test

@cmsbuild
Copy link
Contributor

Pull request #38520 was updated. @Martin-Grunewald, @missirol can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8055c0/25851/summary.html
COMMIT: 68a40ab
CMSSW: CMSSW_12_4_X_2022-06-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38520/25851/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
39634.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675241
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675211
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6cdb03a into cms-sw:CMSSW_12_4_X Jun 29, 2022
@fwyzard fwyzard deleted the hltConvertToRaw branch July 31, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants