Remove Phase-2 bricked pixels specific reconstruction code from CMSSW

[tvami]

PR description:

Resolves #35519
The Phase-2 bricked pixels design was discarded, this PR removes the code from CMSSW

PR validation:

doing

runTheMatrix.py -l limited --ibeos

leads to

49 48 46 35 18 4 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38529/30758

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): [PPS] Direct simulation as sequence #38280, Add run3 tracking low pu era #33532
  • File RecoLocalTracker/SiPixelClusterizer/plugins/PixelThresholdClusterizerForBricked.cc modified in PR(s): Bph reco refactored 12 4 x #38525
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38529/30758/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38529/30758/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38529/30759

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): [PPS] Direct simulation as sequence #38280, Add run3 tracking low pu era #33532
  • File RecoLocalTracker/SiPixelClusterizer/plugins/PixelThresholdClusterizerForBricked.cc modified in PR(s): Bph reco refactored 12 4 x #38525
  • File RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py modified in PR(s): New Heterogeneous Memory Pool #37952

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• Configuration/Eras (operations)
• Configuration/StandardSequences (operations)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoTracker/MeasurementDet (reconstruction)
• RecoTracker/TransientTrackingRecHit (reconstruction)

@perrotta, @clacaputo, @cmsbuild, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@mtosi, @OzAmram, @fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @dkotlins, @ebrondol, @lecriste, @ferencek, @gpetruc, @mmusich, @threus, @dgulhan, @slomeo, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

OK, running limited for 3 hours now, everything looks fine, so I'll make this a full PR and trigger test

[tvami]

@cmsbuild , please test

[tvami]

type performance-improvement,trk

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bbd55d/25854/summary.html
COMMIT: 7d4d2f0
CMSSW: CMSSW_12_5_X_2022-06-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38529/25854/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659995
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3659971
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• minimally resolves Duplication of clusterizers for bricked pixels #35519
• no reco changes (bricked pixel WFs removed)

[tvami]

@cms-sw/operations-l2 this is essentially fully signed

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.