-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix from447 #3853
Fix from447 #3853
Conversation
Fix reweighting for flat QCD
A new Pull Request was created by @UAEDF-tomc (Tom Cornelis) for CMSSW_4_2_X. Fix from447 It involves the following packages: GeneratorInterface/Pythia8Interface @vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks. |
Is it possible to have a more minimal fix for this issue? |
I actually just copied the Pythia8Interface from CMSSW_4_4_7 to this CMSSW_4_2_X branch, as suggested by Mikhail in the hypernews thread. There are indeed a lot of lines changed in the Pythia8Hadronizer.cc, but I think most of them are for lay-out changes and additional options. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_4_2_X IBs unless changes or unless it breaks tests. @smuzaffar, @nclopezo, @davidlt, @ktf can you please take care of it? |
Take the Pythia8Interface from CMSSW_4_4_7 and inplements it in branch CMSSW_4_2_X
This will fix the problem with weights in flat QCD samples