Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from447 #3853

Merged
2 commits merged into from
May 23, 2014
Merged

Fix from447 #3853

2 commits merged into from
May 23, 2014

Conversation

tomcornelis
Copy link
Contributor

Take the Pythia8Interface from CMSSW_4_4_7 and inplements it in branch CMSSW_4_2_X
This will fix the problem with weights in flat QCD samples

Tom Cornelis added 2 commits May 13, 2014 17:07
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @UAEDF-tomc (Tom Cornelis) for CMSSW_4_2_X.

Fix from447

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar, @nclopezo, @davidlt, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

Is it possible to have a more minimal fix for this issue?

@tomcornelis
Copy link
Contributor Author

I actually just copied the Pythia8Interface from CMSSW_4_4_7 to this CMSSW_4_2_X branch, as suggested by Mikhail in the hypernews thread. There are indeed a lot of lines changed in the Pythia8Hadronizer.cc, but I think most of them are for lay-out changes and additional options.
Maybe @mkirsano can comment on this?

@vciulli
Copy link
Contributor

vciulli commented May 20, 2014

+1
I think it is safer to backport the full Pythia8Interface from 447, as it has been extensively tested there

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_4_2_X IBs unless changes or unless it breaks tests. @smuzaffar, @nclopezo, @davidlt, @ktf can you please take care of it?

ghost pushed a commit that referenced this pull request May 23, 2014
Generator fixes -- Fix from447
@ghost ghost merged commit 8a4cbb3 into cms-sw:CMSSW_4_2_X May 23, 2014
@tomcornelis tomcornelis deleted the fixFrom447 branch April 13, 2018 15:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants