Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Fix bug in muon index bit computation #38533

Merged
merged 1 commit into from Jul 1, 2022

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Jun 28, 2022

PR description:

We were previously only doing the data format-based assignment for BMTF muons. This is now extended to also OMTF and EMTF muons. This will mostly have an effect on the DQM, removing uGMT data-emulator mismatches during cosmics data taking. (cc @pmandrik; this is the 12_3_X backport.)

PR validation:

Ran on RAW data locally and confirmed that the index bit mismatches went away.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38532 as I would like this included in the online DQM.

We were previously only doing the data format based assignment for BMTF
muons. This is now extended to also OMTF and EMTF muons.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2022

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_12_3_X.

It involves the following packages:

  • L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5dfd0/25860/summary.html
COMMIT: e5c01de
CMSSW: CMSSW_12_3_X_2022-06-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38533/25860/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3626218
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3626182
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

backport of #38532

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 1, 2022

+1

@cmsbuild cmsbuild merged commit 555c52d into cms-sw:CMSSW_12_3_X Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants