Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tau trigger bits stored in NanoAOD [12_4_X] #38539

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Jun 28, 2022

PR description:

This PR is meant to fix an issue with not matching tau triggers bits in 2018 (due to a forgotten 'Hps' part in their names) as well as to prepare to accommodate Run-3 tau triggers.

This PR is a backport of #38472 (full description therein).

Changes

  • Addition of wildcards to original trigger bits to work for both HPS and non-HPS paths;
  • Addition of DeepTau trigger bits;
  • Addition of bits 4096 to 32768 to include PAG paths;
  • Addition of bits 65536 for completeness, they allow to go a bit more specific in the triggers to select;
  • Addition of boosted tau block. Right now the bits are redundant, but we expect more to be added in the future;
  • Added bits to non-tau blocks from cross triggers.

PR validation:

Reran NanoAOD for all three Run-2 years and in a Run-3 sample, everything seemed to act as expected. In addition tests run during integration to the master.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It is a backport of #38472; it is meant to become a part of nanoAOD v10.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 28, 2022

A new Pull Request was created by @mbluj for CMSSW_12_4_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

backport of #38472

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54bc00/25869/summary.html
COMMIT: 9508c78
CMSSW: CMSSW_12_4_X_2022-06-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38539/25869/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675274
  • DQMHistoTests: Total failures: 173
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3675078
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

+xpog

backport inline with master

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 15ae328 into cms-sw:CMSSW_12_4_X Jun 29, 2022
@mbluj mbluj deleted the CMSSW_12_4_X_tau-pog_tauTrgBitsFixNano branch October 10, 2023 10:02
moritzmolch added a commit to KIT-CMS/gc_configs_for_embedding that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants