Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][GEM] bug fix : typo in GEMOptoHybrid data format [12_4_X] #38573

Merged
merged 1 commit into from Jul 3, 2022

Conversation

yeckang
Copy link
Contributor

@yeckang yeckang commented Jun 30, 2022

PR description:

The mismatching problem of vfatWordCnt in GEMOptoHybrid data has been reported.
And we found out that we made a typo in the function that calls vfatWordCnt from GEMOptoHybrid Trailer.

PR validation:

The personal online DQM module has been performed on the corresponding version of data. And the mismatching problem of vfatWordCnt has disappeared.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

The original PR is #38572

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 30, 2022

A new Pull Request was created by @yeckang (Yechan Kang) for CMSSW_12_4_X.

It involves the following packages:

  • DataFormats/GEMDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @rovere, @eyigitba, @jshlee, @watson-ij, @trtomei, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Jun 30, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c8803/25924/summary.html
COMMIT: cd2f9b0
CMSSW: CMSSW_12_4_X_2022-06-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38573/25924/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675663
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3675639
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 1, 2022

+1

@perrotta
Copy link
Contributor

perrotta commented Jul 1, 2022

backport of #38572

@srimanob
Copy link
Contributor

srimanob commented Jul 3, 2022

+Upgrade

Backport PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 3, 2022

+1
bugfix

@cmsbuild cmsbuild merged commit 23abf3e into cms-sw:CMSSW_12_4_X Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants