Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx316E Add a new scenario 2026D93 for the HGCal version 17 with no explicit cell declaration within full wafers #38582

Merged
merged 2 commits into from Jul 3, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 2, 2022

PR description:

Add a new scenario 2026D93 for the HGCal version 17 with no explicit cell declaration within full wafers. The corresponding workflow for tuba at 14 TeV is 41434.0

PR validation:

Tested for the 2 workflows 41034.0 and 41434.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38582/30831

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)

@perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@beaucero, @fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @kpedro88, @lecriste, @trtomei, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 2, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38582/30832

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2022

Pull request #38582 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 2, 2022

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d63f7/25945/summary.html
COMMIT: 4049438
CMSSW: CMSSW_12_5_X_2022-07-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38582/25945/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3654741
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 2, 2022

+1

@srimanob
Copy link
Contributor

srimanob commented Jul 3, 2022

@cmsbuild please test workflow 41434.0

This is to test new D93 workflow.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d63f7/25952/summary.html
COMMIT: 4049438
CMSSW: CMSSW_12_5_X_2022-07-03-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38582/25952/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4d63f7/41434.0_TTbar_14TeV+2026D93+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3654735
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Jul 3, 2022

+Upgrade

This PR adds a new workflow for D93. PR test of new workflow runs fine.

@kskovpen
Copy link
Contributor

kskovpen commented Jul 3, 2022

+pdmv

@perrotta
Copy link
Contributor

perrotta commented Jul 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c1be270 into cms-sw:master Jul 3, 2022
@bsunanda bsunanda deleted the Phase2-hgx316E branch August 20, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants