Add EGamma calo ID variable cut to Run 3 Scouting Electrons

[arsahasransu]

Co-authored-by: Marino Missiroli m.missiroli@cern.ch

PR description:

Add the sigmaietaieta calo id variable cut to the Run 3 scouting electron collection

• Use the same cut strategy as in the standard electron path.
• Default value is kept so that all the electrons pass without the cut.
• Default implementation is "less than" a certain cut value because the standard use of this variable is var < cut.
• Validated in presentation in the scouting group at https://indico.cern.ch/event/1174315/#1-update-on-scouting-electrons
• The EGamma sigmaietaieta variable will be updated with sigmaietaieta(noisecleaned) variable which can be done as a different collection input to the same variable to that has been left unchanged but will be part of the changes to the scouting path.

PR validation:

To validate the changes in this PR

• We re-emulated the scouting path with MC and 2018 data files.
• Timing and Rate studies were done as well to see if the effect of the PR is as expected.
• All observations were found to be normal.
• In addition all the regular set of check such code-check and code-formatting has also been applied.

Based on comments from Marino Missiroli m.missiroli@cern.ch in a previous version of the PR some changes have already been included. The old PR, which is now closed can be found at #38597.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30877

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for master.

It involves the following packages:

• HLTrigger/Egamma (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30903

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #38602 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[Martin-Grunewald]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d5bcf/26014/summary.html
COMMIT: 0ee4e45
CMSSW: CMSSW_12_5_X_2022-07-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38602/26014/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654771
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3654735
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30916

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30916/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30916/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38602/30979

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #38602 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

please test

[missirol]

@arsahasransu

The EGamma sigmaietaieta variable will be updated with sigmaietaieta(noisecleaned) variable which can be done as a different collection input to the same variable to that has been left unchanged but will be part of the changes to the scouting path.

It sounds like this PR will be followed by a JIRA ticket to make changes to the Scouting Path for the ongoing pp data-taking, which will use CMSSW_12_4_X. If so, a backport of this PR to the CMSSW_12_4_X branch needs to be opened asap.

[arsahasransu]

@missirol Yes, indeed! Thanks for the suggestion. I was planning to do that.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d5bcf/26182/summary.html
COMMIT: a773959
CMSSW: CMSSW_12_5_X_2022-07-12-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38602/26182/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3653966
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3653942
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1