Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Fix DNS servers for BeamSpot DIP publication #38613

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #38611
It was noticed during Fills 7920 and 7921 that the BeamSpot information wasn't being published on DIP.
Following the discussion in https://its.cern.ch/jira/browse/CMSOMS-280 it seems that

We're using redundant peers, and sometimes dns run in 1 and sometimes in 2, depending which of them is active

So both DNS addresses should be used in order to establish a connection.
This PR udpated both flavors of the BeamSpot DIP publisher: the DQM client (currently in production) and the standalone version (to be put in production soon).

PR validation:

Code compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38611

FYI: @sikler @gennai @dzuolo @amassiro

@francescobrivio
Copy link
Contributor Author

backport of #38611

@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone Jul 6, 2022
@francescobrivio
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc6f05/26002/summary.html
COMMIT: bed160c
CMSSW: CMSSW_12_3_X_2022-07-06-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38613/26002/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3626403
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3626379
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

testing at p5

@tvami
Copy link
Contributor

tvami commented Jul 7, 2022

+db

  • this was used yesterday night at P5

@francescobrivio
Copy link
Contributor Author

for reference: this update was succesful and the BeamSpot values are now published in DIP, see #38611 (comment)

@cms-sw/dqm-l2 feel free to sign at your convenience

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor Author

urgent

  • @cms-sw/orp-l2 in case a new 12_3_X release is cut in the next hours it would be good to include this PR, so it doesn't have to be added manually in P5 DQM machines!

@perrotta
Copy link
Contributor

perrotta commented Jul 8, 2022

+1

@cmsbuild cmsbuild merged commit 2fd563a into cms-sw:CMSSW_12_3_X Jul 8, 2022
@francescobrivio francescobrivio deleted the alca-fix_DIP_publication_12_3_X branch September 14, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants