[12_4_X] Emtf Unpacker/Emulator Update for Run 3 CSC TPs

[eyigitba]

PR description:

This PR mainly contains the updates to the EMTF unpacker for CSC inputs. In June we discovered that EMTF DAQ output did not contain all the relevant information for Run 3 CSC TPs. Now that they are added in firmware and tested at P5, we want to update the CMSSW unpacker with these changes.

Bulk of the changes are in EMTFBlockME.cc and ME.h data format. There is a small bug fix in EMTF emulator PrimitiveConversion.cc and one in EMTFBlockSP.cc.

Details of the changes:

• Added new fields in ME.h for Run 3 CSC TP data format. These are the variables related to the CCLUT algorithm and the HMT related variables.
• Modified EMTFBlockME.cc to match the new EMTF DAQ output format. In Run 3, EMTF receives different types of CSC TPs depending on the ring. So, the meanings of some fields in EMTF DAQ is different in ring == 1 vs ring == 2 & 3.
• Modified EMTFBlockME.cc to produce CSCShowerDigiCollection based on HMT related bits in the new DAQ format.
• Added Hit_.Valid() == 1 check to EMTFBlockME.cc. This check will become necessary when EMTF start receiving valid HMTs without valid LCTs (Currently they always come with valid LCTs).
• Fixed the definition of nominal shower bit in EMTFBlockSP.c.
• Fixed a bug in PrimitiveConversion.cc related to the Run 3 CSC TP pattern calculation. Since the Run 3 TPs were not enabled before, this wasn't caught earlier.
• Modified EMTFUnpackerTools.cc and EMTFHit.cc to assign the new Run 3 parameters to the EMTFHit class and CSCCorrelatedLCTDigi made by EMTFHit class.
• Rest of the modifications in L1TRawToDigi are related to producing CSCShowerDigiCollection in EMTFBlockME.cc

We expect some changes in the EMTF emulator behaviour in unpacked data from P5 and also when PR gets merged to enable Run 3 CSC TPs in EMTF.

This PR is necessary to have good data/emulator agreement for EMTF during data taking. So, it needs to be backported to 12_4_X (not super urgent, but the sooner the better)

PR validation:

Validated by doing data/emulator comparisons in private repository which shows 100% agreement.

Also validated by runTheMatrix.py -l limited -i all --ibeos none of the tests failed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport of #38615. The changes in this PR are required to have good data/emulator agreement during data taking.

[cmsbuild]

A new Pull Request was created by @eyigitba for CMSSW_12_4_X.

It involves the following packages:

• DataFormats/L1TMuon (l1)
• EventFilter/L1TRawToDigi (l1)
• L1Trigger/L1TMuonEndCap (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @rovere, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c992ef/26063/summary.html
COMMIT: 446356f
CMSSW: CMSSW_12_4_X_2022-07-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38625/26063/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3675848
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3675812
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #38625 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c992ef/26140/summary.html
COMMIT: b219f60
CMSSW: CMSSW_12_4_X_2022-07-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38625/26140/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676111
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3676087
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1