[12_3_X] Added protection from multiple creation of geometry

[civanch]

PR description:

backport of #38640 in order to fix #38624

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

no

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_12_3_X.

It involves the following packages:

• CalibTracker/SiPixelLorentzAngle (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Added protection from multiple creation of geometry #38640

[civanch]

please test

[perrotta]

@civanch please don't forget the 12_4_x backport (I am a bit more dubtfull about the need of this 12_3_X one...)

[mmusich]

assign trk-dpg

[mmusich]

-1

• tested with the config provided at Segfault in dd4hep geometry when changing runs #38624 and it does NOT fix.

[cmsbuild]

New categories assigned: trk-dpg

@connorpa,@mmusich,@tsusa you have been requested to review this Pull request/Issue and eventually sign? Thanks

[civanch]

@mmusich , the problem is in the same place or in a different one?

[mmusich]

the problem is in the same place or in a different one?

the stack trace is exactly the same as before.
Tested with:

cmsrel CMSSW_12_5_X_2022-07-07-1100
cd CMSSW_12_5_X_2022-07-07-1100/src/
cmsenv
git cms-merge-topic 38640
scram b -j 20
eos cp /eos/cms/store/group/alca_global/multiruns/results/dev02/slc7_amd64_gcc10/CMSSW_12_3_6/378852_0p_3f/alcaConfig.py .
cmsRun alcaConfig.py

[tvami]

@cmsbuild , please abort

[tvami]

(I am a bit more dubtfull about the need of this 12_3_X one...)

Actually we use this module in the multi-run harverster which is using the 12_3_X

[tvami]

-1

• unfortunately doesnt resolve 38624

[mmusich]

@civanch

• please change the title to something more meaningful;
• please incorpotate the last commit from Added protection from multiple creation of geometry #38640
• Also please put in the title that it's for [12.3.X] otherwise it will be confusing.

[tvami]

type bugfix

[tvami]

backport of #38640

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec613b/26083/summary.html
COMMIT: 77613ad
CMSSW: CMSSW_12_3_X_2022-07-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38641/26083/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626403
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3626367
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[mmusich]

+1

• with the understanding that the caveats at [12.4.X] Added protection from multiple creation of geometry #38653 (comment) should be dealt with in a later PR

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1
further improvement tracked with a github issue #38669