Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] update PrimaryVertexMonitor for Run-3 data-taking #38642

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 7, 2022

backport of #38598

PR description:

The goal of this PR is to update the PrimaryVertexMonitor for Run-3 data-taking.
Performed maintenance:

  • added plots of the η and ϕ of tracks associated to the primary vertex (both for pT>1GeV and pT>10GeV);
  • introduced a static constexpr int cmToUm and use it consistently in the file;
  • use default destructor;
  • update the range in η for phase-1 as even if there are tracks up to 3, the tracks at high rapidity are discarded for vertexing resulting in empty bins (see e.g. https://tinyurl.com/2jwhu3wp)
  • re-center in x-y the vertex position plots for Run3: initial Run3 beamspot is at (0.17,-0.18) cm

PR validation:

cmssw compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #38598

@mmusich
Copy link
Contributor Author

mmusich commented Jul 7, 2022

urgent

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/RecoB (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @andrzejnovak, @demuller, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 7, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2914bb/26068/summary.html
COMMIT: a87fb79
CMSSW: CMSSW_12_4_X_2022-07-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38642/26068/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675848
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 415
  • DQMHistoTests: Total successes: 3675404
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 33.42399999999998 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.592 KiB OfflinePV/Alignment
  • DQMHistoSizes: changed ( 10024.0,... ): 0.514 KiB OfflinePV/Alignment
  • DQMHistoSizes: changed ( 11634.0,... ): 1.826 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 23234.0,... ): 0.709 KiB OfflinePV/Alignment
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jul 8, 2022

+1

@cmsbuild cmsbuild merged commit 4c2ef01 into cms-sw:CMSSW_12_4_X Jul 8, 2022
@mmusich mmusich deleted the updatePrimaryVertexMonitorForRun3_12_4_X branch July 8, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants