Fix the inverted condition in the PPS tdc pcl

[ChrisMisan]

PR description:

This is a bugfix of the TDC PCL, which fixes the inverted condition. It was mistakenly deleting all the correct calibrations and saving the incorrect ones.

PR validation:

PR was validated manually with the alcaReco data:
/eos/cms/store/group/dpg_ctpps/comm_ctpps/AlcaPrompt/PromptCalibProdPPSTimingCalib-Express/354332/00000/

Backport:

This PR should be backported to 12_4_X

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38658/30942

• This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38658/30942/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38658/30942/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38658/30943

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

type bugfix

[tvami]

type ctpps

[tvami]

@ChrisMisan you deleted the backport part of the PR description. Please add it back and say you need this in 12_4_X

[tvami]

@ChrisMisan also include something that identifies that this is for PPS in the PR title and description. TDC is used in the HCAL, too I think

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29e41c/26087/summary.html
COMMIT: 31afd40
CMSSW: CMSSW_12_5_X_2022-07-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38658/26087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3655935
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3655905
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• PR is according to the PR description,
• diffs in MsgLogger and MTD only
• @ChrisMisan please submit the 12_4_X backport asap

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1