Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Add new functions to AlCaNano.py needed for the T0 replay #38665

Merged
merged 1 commit into from Jul 11, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jul 9, 2022

PR description:

see #38664

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #38664

@tvami
Copy link
Contributor Author

tvami commented Jul 9, 2022

backport of #38664

@tvami
Copy link
Contributor Author

tvami commented Jul 9, 2022

urgent

  • should be in 12_4_3

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @rappoccio, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jul 9, 2022

type ecal,bugfix

@tvami
Copy link
Contributor Author

tvami commented Jul 9, 2022

assign alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2022

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tvami
Copy link
Contributor Author

tvami commented Jul 9, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88f770/26097/summary.html
COMMIT: e6420e6
CMSSW: CMSSW_12_4_X_2022-07-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38665/26097/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676076
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676046
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

  • verbatim backport
  • will be tested in Tier0 replay

@tvami
Copy link
Contributor Author

tvami commented Jul 11, 2022

@qliphy can you please merge this too? the master IB is fine

@qliphy
Copy link
Contributor

qliphy commented Jul 11, 2022

+1
bug fix

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 3661cdb into cms-sw:CMSSW_12_4_X Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants