[12_4_X] Adding HZZ electron MVA ID

[asculac]

PR description:

Backport of #38355

• adding HZZ training for electron ID, which is an EGgamma-approved ID (latest talk at egamma POG here ) used for H->4l, which cannot otherwise be recomputed on top of nanoAODs.

• It is based on the same electronMVAValueMapProducer used for existing mvaIds, but with an updated and separate training for 2016UL, 2017UL and 2018UL.

• A single variable mvaHZZIso is added to electrons. The appropriate training to be used is selected automatically. The idea is that the variable name will stay the same in the future, selecting a new training when appropriate.

• No need to store working points as bools since these can be easily derived from the MVA value.

• In addition to this PR: renaming mva Egamma IDs to be more generic

PR validation:

• Tested in CMSSW_12_4_0_pre1; verified that the new variable is added correctly.
• Adds 1 float per electron.

This PR is a backport of #38355

[cmsbuild]

A new Pull Request was created by @asculac (Ana Sculac) for CMSSW_12_4_X.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)
• PhysicsTools/PatAlgos (reconstruction)

@gouskos, @clacaputo, @cmsbuild, @fgolf, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @swertz, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Adding HZZ electron MVA ID #38355

[mariadalfonso]

please test

[mariadalfonso]

backport of #38355

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64cfc/26158/summary.html
COMMIT: e011e99
CMSSW: CMSSW_12_4_X_2022-07-11-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38698/26158/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.0

----- Begin Fatal Exception 12-Jul-2022 10:22:00 CEST-----------------------
An exception of category 'UnknownUserFloat' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'dqmoffline_3_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Calling method for module SimpleCandidateFlatTableProducer/'electronTable'
Exception Message:
Requested UserFloat mvaHZZIso is not available! Possible UserFloats are: 
ElectronMVAEstimatorRun2Fall17IsoV1Values ElectronMVAEstimatorRun2Fall17IsoV2Values ElectronMVAEstimatorRun2Fall17NoIsoV1Values ElectronMVAEstimatorRun2Fall17NoIsoV2Values ElectronMVAEstimatorRun2Spring16GeneralPurposeV1Values ElectronMVAEstimatorRun2Spring16HZZV1Values PFIsoAll PFIsoAll04 PFIsoChg ecalTrkEnergyErrPostCorrNew ecalTrkEnergyPostCorrNew ecalTrkEnergyPreCorrNew energyScaleDownNew energyScaleUpNew energySigmaDownNew energySigmaUpNew jetNDauChargedMVASel miniIsoAll miniIsoChg ptRatio ptRel 
----- End Fatal Exception -------------------------------------------------

• 11634.7

----- Begin Fatal Exception 12-Jul-2022 10:22:47 CEST-----------------------
An exception of category 'UnknownUserFloat' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'dqmoffline_3_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Calling method for module SimpleCandidateFlatTableProducer/'electronTable'
Exception Message:
Requested UserFloat mvaHZZIso is not available! Possible UserFloats are: 
ElectronMVAEstimatorRun2Fall17IsoV1Values ElectronMVAEstimatorRun2Fall17IsoV2Values ElectronMVAEstimatorRun2Fall17NoIsoV1Values ElectronMVAEstimatorRun2Fall17NoIsoV2Values ElectronMVAEstimatorRun2Spring16GeneralPurposeV1Values ElectronMVAEstimatorRun2Spring16HZZV1Values PFIsoAll PFIsoAll04 PFIsoChg ecalTrkEnergyErrPostCorrNew ecalTrkEnergyPostCorrNew ecalTrkEnergyPreCorrNew energyScaleDownNew energyScaleUpNew energySigmaDownNew energySigmaUpNew jetNDauChargedMVASel miniIsoAll miniIsoChg ptRatio ptRel 
----- End Fatal Exception -------------------------------------------------

• 11634.914

----- Begin Fatal Exception 12-Jul-2022 10:23:42 CEST-----------------------
An exception of category 'UnknownUserFloat' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'dqmoffline_3_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Calling method for module SimpleCandidateFlatTableProducer/'electronTable'
Exception Message:
Requested UserFloat mvaHZZIso is not available! Possible UserFloats are: 
ElectronMVAEstimatorRun2Fall17IsoV1Values ElectronMVAEstimatorRun2Fall17IsoV2Values ElectronMVAEstimatorRun2Fall17NoIsoV1Values ElectronMVAEstimatorRun2Fall17NoIsoV2Values ElectronMVAEstimatorRun2Spring16GeneralPurposeV1Values ElectronMVAEstimatorRun2Spring16HZZV1Values PFIsoAll PFIsoAll04 PFIsoChg ecalTrkEnergyErrPostCorrNew ecalTrkEnergyPostCorrNew ecalTrkEnergyPreCorrNew energyScaleDownNew energyScaleUpNew energySigmaDownNew energySigmaUpNew jetNDauChargedMVASel miniIsoAll miniIsoChg ptRatio ptRel 
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 11634.911
• 12434.0
• 11834.0

RelVals-INPUT

• 136.72412136.72412_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM.log

[cmsbuild]

Pull request #38698 was updated. @gouskos, @clacaputo, @cmsbuild, @fgolf, @jpata, @mariadalfonso can you please check and sign again.

[asculac]

I forgot to set mvaHZZIso to None also for run3_nanoAOD_devel, I apologize for this overlook. It should be okay now

[gouskos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64cfc/26169/summary.html
COMMIT: b60e07a
CMSSW: CMSSW_12_4_X_2022-07-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38698/26169/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 93 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676071
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3676029
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.309 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1325.81 ): -0.188 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 136.8523 ): -0.125 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[gouskos]

+xpog
Thanks @asculac. Modifications in line with PR description

[clacaputo]

+reconstruction

• RECO differences are related to the new variable "mvaHZZIso", not present in the reference release. This new var shifts some electronTable columns, introducing some artefact differences. See Adding HZZ electron MVA ID #38355
• backport is in line with the original pr

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1