Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71X - add test for CA8 jets #3872

Merged
merged 4 commits into from May 15, 2014
Merged

Conversation

vadler
Copy link

@vadler vadler commented May 14, 2014

A test to produce CA8PFJetsPruned has been added to the PAT.
This uncovered problems, when an identical jet correction label is used for different jet inputs, where modules got unintentionally overwritten. this was solved by adding the used jet label also to the corresponding producer( label)s additionally to the jet correction label.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_1_X.

71X - add test for CA8 jets

It involves the following packages:

PhysicsTools/PatAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #3872 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

@monttj
Copy link
Contributor

monttj commented May 14, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request May 15, 2014
PhysicsTools/PatAlgos -- 71X - add test for CA8 jets
@nclopezo nclopezo merged commit 37629bf into cms-sw:CMSSW_7_1_X May 15, 2014
@vadler vadler deleted the 71X-addJetsCA8 branch May 15, 2014 09:45
@cmsbuild
Copy link
Contributor

vadler pushed a commit to vadler/cmssw that referenced this pull request May 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants