Avoid ID collisions between ED and ES modules in MessageLogger

[Dr15Jones]

PR description:

Separate IDs used by ED and ES modules when checking cache in MessageLogger.

PR validation:

Test case from reported issue now fixed.

fixes #38724

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38728/31031

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/MessageService (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c3c19/26215/summary.html
COMMIT: 731f637
CMSSW: CMSSW_12_5_X_2022-07-13-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38728/26215/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3653966
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3653936
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[makortel]

Seems that this PR caused a unit test to fail FWCore/Utilities

===== Test "TestSubProcess" ====
argument 0: TestSubProcess
argument 1: /bin/bash
argument 2: FWCore/Integration/test
argument 3: run_SubProcess.sh
shell is: /bin/bash
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300
topdir is: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300
testdir is: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300/src/FWCore/Integration/test
tmpdir is: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300/tmp/el8_amd64_gcc10
testbin is: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300/test/el8_amd64_gcc10
Running script: /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300/src/FWCore/Integration/test/run_SubProcess.sh
/data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300/tmp/el8_amd64_gcc10 /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_12_5_X_2022-07-14-2300
cmsRun testSubProcess_cfg.py
14a15
>    25 Tracer               -s DoodadESSource:D                       4        4
Failure comparing testSubProcess.grep.txt: status 1
status = 256

---> test TestSubProcess had ERRORS

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc10/CMSSW_12_5_X_2022-07-14-2300/unitTestLogs/FWCore/Integration#/11718-11718

Maybe it is just about updating the reference log file?