Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made statics into atomics in CSCALCTTrailer #3876

Merged

Conversation

Dr15Jones
Copy link
Contributor

Changed statics to atomics becuase helgrind was reporting thread
safety issues.
NOTE: It would be much better if firmwareVersion was made a regular
member data instead of a static. When we are processing multiple
runs simultaneously we may need more than one value in the job.

Changed statics to atomics becuase helgrind was reporting thread
safety issues.
NOTE: It would be much better if firmwareVersion was made a regular
member data instead of a static. When we are processing multiple
runs simultaneously we may need more than one value in the job.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Made statics into atomics in CSCALCTTrailer

It involves the following packages:

EventFilter/CSCRawToDigi

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented May 15, 2014

+1

for #3876 66f98f3
jenkins runs ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 15, 2014
Made statics into atomics in CSCALCTTrailer
@davidlange6 davidlange6 merged commit 30568b8 into cms-sw:CMSSW_7_1_X May 15, 2014
@Dr15Jones Dr15Jones deleted the makeStaticAtomicCSCALCTTrailer branch June 12, 2014 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants