New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip PPS diamond calibration if there are no parameters #38763
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38763/31090
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
012ae10
to
2e660e1
Compare
type bug-fix, ctpps |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38763/31091
|
A new Pull Request was created by @ChrisMisan (Christopher) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
urgent
|
test parameters: workflow = 1041 |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5b4d2/26276/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
There was a possibility of crash in:
cmssw/RecoPPS/Local/src/CTPPSDiamondRecHitProducerAlgorithm.cc
Line 77 in 2a0aaba
if the calibration was not produced for a given channel. This fix adds the condition to handle this scenario.
PR validation:
Can be validated with relval 1041
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR should be backported to the 12_4_X