Adding extra protection against invalid data to EMTF PrimitiveSelection #38775
Conversation
…his is necessary for Run 3 CSC TPs when CCLUT is not running correctly.
|
@cmsbuild , please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38775/31111
|
|
A new Pull Request was created by @eyigitba for master. It involves the following packages:
@epalencia, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5e578/26302/summary.html Comparison SummarySummary:
|
|
+l1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -172,4 +172,13 @@ namespace emtf { | |||
| return std::make_pair(max_pattern, max_quality); | |||
| } | |||
|
|
|||
| int get_csc_max_slope(int station, int ring, bool useRun3CCLUT_OTMB, bool useRun3CCLUT_TMB) { | |||
There was a problem hiding this comment.
Why is station needed here?
There was a problem hiding this comment.
I added the station there as well to be safe. Currently it's not needed, but I don't know if there will be a station based enabling of CCLUT algorithm in the future. This is also the reason station and ring are there for other functions like get_csc_max_pattern_and_quality.
|
+1 |
PR description:
During the tests of #38373 we realized that EMTF
PrimitiveSelection.ccwas missing protection against invalid CSC data that is enabled with Run 3 flagsuseRun3CCLUT_OTMBanduseRun3CCLUT_TMB.This protection is necessary for Run 3 CSC TPs when CCLUT is not running correctly at P5 which was the case before June 2022.
The slope variable is a
uint16_tand it exists for Run 2 or Run 3 CSC TPs. We only use this variable ifuseRun3CCLUT_OTMBoruseRun3CCLUT_TMBis enabled. That's why I left the max value as 65536 if these flags are disabled.PR validation:
Validated by checking failed workflows from #38373. We see correct behaviour of rejecting these "corrupt" LCTs and it doesn't change the outcome of the correct LCTs.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: