Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify HG PCL Alignment movement histograms for use in the DQM GUI (Backport of #38815 ) #38827

Merged
merged 2 commits into from Jul 23, 2022

Conversation

mteroerd
Copy link
Contributor

PR description:

This PR is in preparation of style changes for the movement histograms displayed in the DQM GUI. This includes the following changes:

  • Fixing the order of labels in the status histogram to correctly match the variables
  • Adding 5 Additional bins to each movement histogram. The first additional bin is empty, the other ones include cut values on movement threshold, significance, maximum error, and maximum movement. These can be read out in the DQM GUI.

PR validation:

Mille & Pede steps were execute to produce ROOT files usable by the DQM GUI. It was confirmed that the changes to the histograms are as intended.

Backport of #38815

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 21, 2022

A new Pull Request was created by @mteroerd (Marius Teroerde) for CMSSW_12_4_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

backport of #38815

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

type trk,bugfix

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

test parameters:

workflows = 1001.2, 1001.3

@tvami
Copy link
Contributor

tvami commented Jul 21, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-988a39/26390/summary.html
COMMIT: 896eadd
CMSSW: CMSSW_12_4_X_2022-07-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38827/26390/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3676162
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 22, 2022

+alca

  • 1001.2, 1001.3 passed

@tvami
Copy link
Contributor

tvami commented Jul 22, 2022

urgent

  • should be part of next 12_4_X

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 23, 2022

+1

@cmsbuild cmsbuild merged commit e63cf26 into cms-sw:CMSSW_12_4_X Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants