Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit AlCaPPS_Run3 from AlCa #38837

Merged
merged 1 commit into from Jul 23, 2022
Merged

Inherit AlCaPPS_Run3 from AlCa #38837

merged 1 commit into from Jul 23, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jul 22, 2022

PR description:

Recent failure at T0 revealed that AlCaPPS_Run3 was missing some functions, this PR fixes that.

PR validation:

python3 Configuration/DataProcessing/test/RunRepack.py --lfn file /eos/cms/store/t0streamer/Data/ALCAPPS/000/355/559/run355559_ls0012_streamALCAPPS_StorageManager.dat 
python3 Configuration/DataProcessing/test/RunExpressProcessing.py --scenario AlCaPPS_Run3 --global-tag 123X_dataRun3_Express_v10 --lfn file:write_PrimDS1_RAW.root --alcareco PPSCalMaxTracks
python3 Configuration/DataProcessing/test/RunAlcaSkimming.py --scenario AlCaPPS_Run3 --global-tag 123X_dataRun3_Prompt_v12 --lfn=file:output.root --skims PromptCalibProdPPSTimingCalib
python3 Configuration/DataProcessing/test/RunAlcaHarvesting.py --scenario AlCaPPS_Run3 --global-tag 123X_dataRun3_Prompt_v12 --lfn=file:output.root --alcapromptdataset PromptCalibProdPPSTimingCalib --dataset /A/B/C

leads to

Dataset: /A/B/C
Traceback (most recent call last):
  File "/build/tvami/AlCaDBPRs/PPSScenarioFix/CMSSW_12_5_X_2022-07-22-1100/src/Configuration/DataProcessing/test/RunAlcaHarvesting.py", line 71, in __call__
    process = scenario.alcaHarvesting(self.globalTag, self.dataset, **kwds)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc10/cms/cmssw/CMSSW_12_5_X_2022-07-22-1100/src/Configuration/DataProcessing/python/Scenario.py", line 153, in alcaHarvesting
    raise NotImplementedError(msg)
NotImplementedError: Scenario Implementation AlCaPPS_Run3
Does not contain an implementation for alcaHarvesting

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/build/tvami/AlCaDBPRs/PPSScenarioFix/CMSSW_12_5_X_2022-07-22-1100/src/Configuration/DataProcessing/test/RunAlcaHarvesting.py", line 148, in <module>
    harvester()
  File "/build/tvami/AlCaDBPRs/PPSScenarioFix/CMSSW_12_5_X_2022-07-22-1100/src/Configuration/DataProcessing/test/RunAlcaHarvesting.py", line 76, in __call__
    raise RuntimeError(msg)
RuntimeError: Error creating AlcaHarvesting config:
Scenario Implementation AlCaPPS_Run3
Does not contain an implementation for alcaHarvestin

w/o this PR.

After this PR it runs fine.

Unit test also works.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but needs to go back to 12_4_X

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

type bugfix,ctpps

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

urgent

  • backport is urgent

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

@cmsbuild , please test

  • relying on unit tests in CMSSW, otherwise real validation is done as described in the description

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38837/31219

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @qliphy, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jul 22, 2022

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebf92e/26405/summary.html
COMMIT: 31da5f4
CMSSW: CMSSW_12_5_X_2022-07-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38837/26405/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3706484
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3706454
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+1

@tvami
Copy link
Contributor Author

tvami commented Jul 23, 2022

@cms-sw/orp-l2 we are essentially fully signed

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 8383075 into cms-sw:master Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants