Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Correct the sampic record name #38844

Merged

Conversation

ChrisMisan
Copy link
Contributor

@ChrisMisan ChrisMisan commented Jul 23, 2022

PR description:

This PR resolves PCL harvester crash by correcting the sampic record name.

PR validation:

PR was validated with the tarball /afs/cern.ch/user/c/cmst0/public/PausedJobs/ALCAPPS/job_27. The PR will be followed by the new relval test for sampic PCL.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #38843

@ChrisMisan
Copy link
Contributor Author

type ctpps, bug-fix

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ChrisMisan (Christopher) for CMSSW_12_4_X.

It involves the following packages:

  • CondFormats/Common (db, alca)
  • Configuration/StandardSequences (operations)

@perrotta, @malbouis, @rappoccio, @yuanchao, @tvami, @cmsbuild, @ggovi, @qliphy, @francescobrivio, @ChrisMisan, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @rovere, @lecriste, @mmusich, @mtosi, @dgulhan, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@ChrisMisan
Copy link
Contributor Author

urgent

  • this backport is needed for the next release

@ChrisMisan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35546e/26418/summary.html
COMMIT: 3a38201
CMSSW: CMSSW_12_4_X_2022-07-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38844/26418/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 25, 2022

+1

  • PR is according to the description
  • tests pass, master PR in IBs for a day

@tvami
Copy link
Contributor

tvami commented Jul 26, 2022

@cms-sw/orp-l2 so as we agreed, this should be merged and go into 12_4_4 thanks

@qliphy
Copy link
Contributor

qliphy commented Jul 26, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 051b47b into cms-sw:CMSSW_12_4_X Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants