Integration of alpaka and macro-based SoA in CMSSW #38855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General notes:
- code in the alpaka subdirectories is compiled multiple times, once
for each backend; this is controlled by the ALPAKA_BACKENDS flag in
each package or plugins BuildFile.xml;
- code in .cc files is always compiled by the host compiler;
- code in .dev.cc files is compiled the respective device compiler:
nvcc for CUDA, hipcc for HIP, gcc for the serial or tbb backends.
The HeterogeneousCore/AlpakaInterface package provides an interface to
the header-only alpaka external library.
It provides a definition of the common types and macros used in CMSSW,
of the host types, and of the accelertor devices, queues and events for
each backend.
It also provides a free function to access the common host object.
This package can safely be used by DataFormats packages.
The DataFormats/Portable package implements template wrappers for
persistent host-only collections, transient device-only collections, and
common interface for both.
See DataFormats/Portable/README.md for more information.
The DataFormats/PortableTestObjects package implements portable SoA-based
data formats used for testing the alpaka build rules and the SoA
templates.
The HeterogeneousCore/AlpakaTest package implements modules for
producing, transferring, and analysing those objects.
See HeterogeneousCore/AlpakaTest/test/ for unit tests for writing and
reading SoA data structures.
The HeterogeneousCore/AlpakaServices provides simple services for
checking the availability of devices for each alpaka backend.
Implement a ConstBuffer interface for non-mutable buffers, based on alpaka::ViewConst<Buffer> . Remove the LogDebug messages from the constructors and destructors.
This lets the compiler automatically convert a View to a ConstView when passed by pointer or by reference, emulating the usual conversion rules for mutable/const pointers and references. Various improvements: - fix const correctness in View::Metadata and SoAColumnAccessorsImpl; - make SOA_INLINE always inline also on the host; - simplify the Matryoshka templates; - use the __trap() intrinsic in gpu code; - replace typedef with using; - add missing type aliases; - add defaulted copy/move ctors and dtors; - make various methods constexpr; - add and update comments, remove unused methods and macros; - improve spacing and indentations; - apply code formatting.
This is limited to view trivially deducted from layouts, not the manually defined ones.
2 tasks
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38855/31256
|
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
The following packages do not have a category, yet: HeterogeneousCore/AlpakaServices @cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+heterogeneous |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1321e/26442/summary.html Comparison SummarySummary:
|
perrotta
reviewed
Jul 26, 2022
| namespace portabletest { | ||
|
|
||
| // import the top-level portabletest namespace | ||
| using namespace ::portabletest; |
There was a problem hiding this comment.
Rule1 : https://raw.githubusercontent.com/cms-sw/cmssw/master/Utilities/ReleaseScripts/python/cmsCodeRules/config.py
Search for "using namespace" or "using std::" in header files
/DataFormats/PortableTestObjects/interface/alpaka/TestDeviceCollection.h
[13]
/AlpakaInterface/interface/config.h
[43, 69, 95, 121]
even though in this context it may probably make sense
There was a problem hiding this comment.
Thanks @perrotta for checking. The main reason for this code rule check is to avoid using namespace X to add names into the global namespace. The relevant C++ Core Guideline is https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf7-dont-write-using-namespace-at-global-scope-in-a-header-file. This line adds the names into another namespace, which is ok (one could argue our checker is too eager to warn).
|
|
||
| #ifdef ALPAKA_ACC_GPU_CUDA_ENABLED | ||
| namespace alpaka_cuda_async { | ||
| using namespace alpaka_common; |
There was a problem hiding this comment.
These also probably make sense...
There was a problem hiding this comment.
This case is similar, and is ok.
|
+1 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is a re-posting of #37716 to fix the bot labels.
It introduces examples with the integration of alpaka in CMSSW, and the use of macro-based SoA data structres.
PR validation:
run successfully, both with and without a GPU, using a
SwitchProducerCUDAto choose the modules to run.In both cases, the
test.rootfile created by thewriter.pyconfiguration contains the same collections:Open issues, to be followed up in future PRs
beginStream()andendStream(), because they can be called under unexpected conditions (see Integration of alpaka and macro-based SoA in CMSSW #37716 (comment))