Add GEM recHits and segments to AlCaRecos

[hyunyong]

PR description:

Add GEM recHits and segments in ALCARECOMuAlCalIsolatedMu, ALCARECOMuAlGlobalCosmics, and ALCARECOMuAlGlobalCosmicsInCollisions.

Need to backport to 12_4_X.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38859/31269

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

test parameters:

• workflows = 1001.3,1002.3

[tvami]

@hyunyong you dont have the numbers on the size increase, do you?

[tvami]

@cmsbuild , please test

[tvami]

Please also modify the PR title

[hyunyong]

@hyunyong you dont have the numbers on the size increase, do you?

No, I don't know but I will ask it at the GEM DPG meeting tomorrow.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-654334/26453/summary.html
COMMIT: 31274fd
CMSSW: CMSSW_12_5_X_2022-07-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38859/26453/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-654334/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-654334/1002.3_RunZeroBias2022B+RunZeroBias2022B+TIER0PROMPTRUN3+ALCASPLITRUN3+ALCAHARVDEXPRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 3697418
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697394
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 218 log files, 47 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38859/31281

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #38859 was updated. @malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-654334/26471/summary.html
COMMIT: d071d1f
CMSSW: CMSSW_12_5_X_2022-07-26-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38859/26471/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-654334/1001.3_RunSingleMuon2022B+RunSingleMuon2022B+TIER0EXPRUN3+ALCAEXPRUN3+ALCAHARVDEXPRUN3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-654334/1002.3_RunZeroBias2022B+RunZeroBias2022B+TIER0PROMPTRUN3+ALCASPLITRUN3+ALCAHARVDEXPRUN3

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 3697418
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3697382
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 218 log files, 47 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[hyunyong]

I have checked the output and the MuAlCalIsolated skim contains GEM recHits and segments now.

[tvami]

That's great, can we please have a the numbers for the increase of size before merging the PR?

[hyunyong]

That's great, can we please have a the numbers for the increase of size before merging the PR?

Yes, I processed 1,000 events and the size difference is 77894 bytes. So, average size of GEM recHits and segments is 78 bytes/event.

[tvami]

So I believe that's a 2% increase, for an ALCARECO, that's probably fine. Ok, I'll sign it now, and please prepare the backport

[tvami]

+alca

• tests pass and produce the ALCARECO, which now contains the new collections
• size increase is acceptable

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[hyunyong]

So I believe that's a 2% increase, for an ALCARECO, that's probably fine. Ok, I'll sign it now, and please prepare the backport

Yes, I made the backport #38876

[qliphy]

+1