New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically size the Pixel FED buffer used by SiPixelRawToClusterCUDA [12.4.x] #38902
Conversation
Allocate a WordFedAppender for each event using non-write-conbined, pinned memory (generally from the host caching allocator) based on the actual size of the FEDs. This makes the MaxFEDWords configuration parametere obsolete. It is still kept for backwards compatibility with older configurations, but it will not be written to the cfi files and will be ignored if present.
backport #38868 |
type bugfix |
enable gpu |
please test |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X. It involves the following packages:
@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a7aeb/26538/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
urgent |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Automatically resize the Pixel FED buffer used by
SiPixelRawToClusterCUDA
to construct a contiguous copy of the FED data to be copied to the GPU.The value of the
MaxFEDWords
parameter is not used. It is kept for backwards compatibility with older configurations, but it will not be written to the cfi files and will be ignored if present.PR validation:
Tested on events from run 355872 that would crash with a segmentation fault or raise an exception, because the Pixel had a larger occupancy than expected.
With these changes all crashes disappear.
If this PR is a backport please specify the original PR and why you need to backport that PR.
Backport of #38868 to 12.4.x for data taking.